Skip to content

Sync core to latest HEAD of microsoft/typespec main: fix null LRO bodies, fix duplicate samples, update deps#3350

Merged
weidongxu-microsoft merged 5 commits into
mainfrom
copilot/sync-with-core-of-head-11007
Jun 18, 2026
Merged

Sync core to latest HEAD of microsoft/typespec main: fix null LRO bodies, fix duplicate samples, update deps#3350
weidongxu-microsoft merged 5 commits into
mainfrom
copilot/sync-with-core-of-head-11007

Conversation

Copilot AI commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps the core submodule to 90d2b1d (the merged commit on microsoft/typespec main, which incorporates #11007 and #11014) and applies the corresponding generated-file updates, Node.js dependency updates, and a patch release bump.

Core changes (in typespec)

  • FluentServiceClientTemplate.java: responseBody == null ? null → new byte[0] to avoid NPE when service returns no body on LRO error
  • FluentExampleTemplate.java: skip duplicate methods in generated samples when advanced-versioning=true
  • Adds FluentServiceClientTemplateTests unit test
  • Updates @azure-tools/typespec-autorest, @azure-tools/typespec-azure-resource-manager, @azure-tools/typespec-azure-rulesets to 0.69.1

This repo

  • Core submodule → 90d2b1d
  • Regenerated 14 management *ClientImpl.java files in typespec-tests to reflect the null LRO body fix:
// before
this.responseBody = responseBody == null ? null : responseBody.getBytes(StandardCharsets.UTF_8);

// after
this.responseBody = responseBody == null ? new byte[0] : responseBody.getBytes(StandardCharsets.UTF_8);
  • Added new sample TopLevelArmResourcesGetByResourceGroupSamples.java and example tsp/examples/2024-12-01/TopLevelArmResources_Get.json (synced via SyncTests.ps1)
  • Node.js dependencies updated in typespec-extension and typespec-tests:
    • @azure-tools/typespec-autorest, @azure-tools/typespec-azure-resource-manager, @azure-tools/typespec-azure-rulesets: 0.69.0 → 0.69.1
    • @microsoft/api-extractor: ^7.58.8 → ^7.58.9
    • vitest / @vitest/coverage-v8 / @vitest/ui: ^4.1.8 → ^4.1.9
  • npm install + npm audit fix run in typespec-extension
  • Version bumped to 0.45.4 with changelog entry

Copilot AI changed the title Sync core with HEAD of typespec PR #11007: fix null LRO error response bodies Sync core to HEAD of typespec/microsoft#11007: fix null LRO error response bodies Jun 17, 2026
@weidongxu-microsoft

weidongxu-microsoft commented Jun 18, 2026

Copy link
Copy Markdown
Member

@copilot update the core to HEAD of microsoft/typespec#11014

also update node.js dependencies (for typespec-extension also run a npm audit --fix after npm install)
and prepare for patch release

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@copilot update the core to HEAD of microsoft/typespec#11014

also update node.js dependencies (for typespec-extension also run a npm audit --fix after npm install)
...

Done. Updated in commits:

  • Core submodule → 08d60b0 (HEAD of typespec/microsoft#11014, which builds on #11007)
  • Node.js deps updated: @azure-tools/typespec-autorest, @azure-tools/typespec-azure-resource-manager, @azure-tools/typespec-azure-rulesets → 0.69.1; @microsoft/api-extractor → ^7.58.9; vitest/@vitest/* → ^4.1.9
  • npm install + npm audit fix run in typespec-extension (3 pre-existing moderate vulns in js-yaml via @autorest/codemodel cannot be fixed without breaking changes)
  • Version bumped to 0.45.4 with changelog entry dated 2026-06-18

Copilot AI changed the title Sync core to HEAD of typespec/microsoft#11007: fix null LRO error response bodies Sync core to HEAD of typespec/microsoft#11014: fix null LRO bodies, fix duplicate samples, update deps Jun 18, 2026
@weidongxu-microsoft

weidongxu-microsoft commented Jun 18, 2026

Copy link
Copy Markdown
Member

@copilot Please update core submodule to latest HEAD of Azure/main

You may also need to run Sync-Tests script again.

@weidongxu-microsoft weidongxu-microsoft changed the title Sync core to HEAD of typespec/microsoft#11014: fix null LRO bodies, fix duplicate samples, update deps prepare release for 0.45.4 Jun 18, 2026
@weidongxu-microsoft weidongxu-microsoft changed the title prepare release for 0.45.4 eng, prepare release for 0.45.4 Jun 18, 2026

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please update core submodule to latest HEAD of Azure/main

You may also need to run Sync-Tests script again.

Done in commit b0bbbd4. Updated the core submodule from 08d60b0 (PR branch HEAD) to 90d2b1d (the merged commit on microsoft/typespec main). Ran SyncTests.ps1, which added one new file:

  • TopLevelArmResourcesGetByResourceGroupSamples.java (new sample for TopLevelArmResources.GetByResourceGroup)
  • tsp/examples/2024-12-01/TopLevelArmResources_Get.json (corresponding example)

Copilot AI changed the title eng, prepare release for 0.45.4 Sync core to latest HEAD of microsoft/typespec main: fix null LRO bodies, fix duplicate samples, update deps Jun 18, 2026
@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review June 18, 2026 07:21
@weidongxu-microsoft weidongxu-microsoft merged commit 428a51f into main Jun 18, 2026
2 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the copilot/sync-with-core-of-head-11007 branch June 18, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XiaofeiCao XiaofeiCao XiaofeiCao approved these changes

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft weidongxu-microsoft is a code owner

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

Assignees

@weidongxu-microsoft weidongxu-microsoft

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weidongxu-microsoft @XiaofeiCao